[MOO-1836]: fix feedback widget logo issues and make WCAG compliant#490
[MOO-1836]: fix feedback widget logo issues and make WCAG compliant#490
Conversation
| titleSending?: DynamicValue<string>; | ||
| titleResult?: DynamicValue<string>; | ||
| labelFeedbackInput?: DynamicValue<string>; | ||
| placeholderFeedback?: DynamicValue<string>; |
There was a problem hiding this comment.
As we discussed , these props are added to the component to support the language translation . I think we are making component heavy by introducing these props for only the language purpose . Can we avoid these ?
There was a problem hiding this comment.
To add to this, I am a bit suspicious of handling localization in this manner, since no other Widget does it like this i.e. 'passing props for individual text fields'.
Maybe it is the responsibility of the User to manage different DataSources dynamically and Studio Pro should only expose the fields for override.
There was a problem hiding this comment.
After clarification with Saurabh, the changes here do not actually affect the existing attributes of the Widget on Studio Pro, but rather are used as sources of text instead of the hardcoded strings in the Feedback widget.
This sounds ok, but of course it is probably part of a greater task to do this in the scope of the entire widgets i.e. proper localization, single-source of truth for the localize-able strings instead of hardcoding them within widgets etc.
Vadym will continue taking a look at this for some context and suggestions.
Thank you!
5 participants
Checklist
[XX-000]: description)? ✅This PR contains
Relevant changes
Feedback widget strings were hardcoded, they were updated to enable language translation.
Custom logo issue was fixed.